Upgrade pre-commit repos and add ruff-check; add "dev" optional #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwtoews
force-pushed
the
up-pre-commit-add-dev
branch
from
2bcabb1 to
e297ee5
Compare
Collaborator
|
Thanks Mike. Is there any point continuing to run pylint, if we add normal Ruff, or can that be dropped? |
Contributor
Author
|
I'm considering that too, but for a later PR. I think there could be a few missing rules in ruff for pylint, but I could be mistaken. Certainly the main rules are fully implemented in ruff. |
Collaborator
|
|
JamesParrott
force-pushed
the
up-pre-commit-add-dev
branch
from
e297ee5 to
556c7cb
Compare
Collaborator
|
Thanks Mike. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few useful things:
pre-commit autoupdate),noqa: E722to ignore bare exceptuv sync --all-extras(docs here). In otherwords, it allowspip install -e .[dev]to install development tools as the optional/extra.